feat: liquidity migrator deployment #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotzenx
previously approved these changes
Dec 24, 2024
0xDiscotech
reviewed
Dec 24, 2024
Comment on lines
45
to
46
| uint256 _portalEthBalance = address(optimismPortal2).balance; | ||
| uint256 _lockboxBalanceBefore = address(sharedLockbox).balance; |
There was a problem hiding this comment.
NIT
Suggested change
| uint256 _portalEthBalance = address(optimismPortal2).balance; | |
| uint256 _lockboxBalanceBefore = address(sharedLockbox).balance; | |
| uint256 portalEthBalance = address(optimismPortal2).balance; | |
| uint256 lockboxBalanceBefore = address(sharedLockbox).balance; |
|
|
||
| // Get the balance of the migrator before the migration to compare later on the assertions | ||
| uint256 _migratorEthBalance = address(migrator).balance; | ||
| uint256 _migratorEthBalance = address(liquidityMigrator).balance; |
There was a problem hiding this comment.
We should also remove the underscores from the stack vars introduced on previous PRs
Suggested change
| uint256 _migratorEthBalance = address(liquidityMigrator).balance; | |
| uint256 migratorEthBalance = address(liquidityMigrator).balance; |
0xDiscotech
previously approved these changes
Dec 24, 2024
0xDiscotech
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.